Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.1] Java bug-fix cherry pick #14834

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Conversation

lanking520
Copy link
Member

Description

Include some very important bug fix on Scala/Java API.
@zachgk @junrushao1994 @yzhliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520
Copy link
Member Author

Since the CI crashed on the Python test, Scala/Java portion is not impacted

@junrushao
Copy link
Member

The CI is due to irrelevant python timeout. Should be good to merge

@lanking520 lanking520 merged commit 69515c2 into apache:v1.4.x Apr 29, 2019
@lanking520 lanking520 deleted the 1.4javabug branch June 21, 2019 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants