Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve dev_menu virtualenv handling #14788

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 24, 2019

Description

Fixes a bug where pip was being called globally and thus not installing mxnet inside the virtualenv.
Activation of virtualenvs inside Python seems not possible.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy
Copy link
Contributor Author

larroy commented Apr 24, 2019

@mxnet-label-bot add [pr-awaiting-review, Build]

@anirudhacharya
Copy link
Member

@marcoabreu @lanking520 can you review this PR

@vandanavk
Copy link
Contributor

LGTM

@marcoabreu marcoabreu merged commit 13f81a0 into apache:master May 9, 2019
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants