This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-978] Fully connected, higher order grad #14779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larroy
force-pushed
the
fc_higher_order_grad
branch
from
April 23, 2019 21:49
a6ca88a
to
f2a63de
Compare
@mxnet-label-bot add [Autograd, Backend, pr-work-in-progress, pr-awaiting-review] |
marcoabreu
added
Autograd
Backend
Issues related to the backend of MXNet
pr-awaiting-review
PR is waiting for code review
pr-work-in-progress
PR is still work in progress
labels
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
apeforest
reviewed
Apr 23, 2019
@larroy Thanks for the contribution. Could you please add unit test and change the title if it's ready for review? |
Why are there changes in submodules? |
Ignore submodules, I guess I was out of date. I will sync them on the next commits. |
larroy
force-pushed
the
fc_higher_order_grad
branch
2 times, most recently
from
April 26, 2019 21:00
01e6c92
to
25fda1d
Compare
larroy
force-pushed
the
fc_higher_order_grad
branch
from
May 6, 2019 06:34
25fda1d
to
684fac7
Compare
larroy
force-pushed
the
fc_higher_order_grad
branch
2 times, most recently
from
May 24, 2019 21:49
bca77ba
to
855e7d8
Compare
larroy
changed the title
[WIP] Fully connected, higher order grad
Fully connected, higher order grad
May 28, 2019
larroy
force-pushed
the
fc_higher_order_grad
branch
2 times, most recently
from
June 5, 2019 18:50
c3326f1
to
7458af5
Compare
@apeforest @kshitij12345 please review |
@mxnet-label-bot remove [pr-work-in-progress] |
larroy
changed the title
Fully connected, higher order grad
[Don't merge] Fully connected, higher order grad
Jun 6, 2019
kshitij12345
reviewed
Jun 7, 2019
kshitij12345
reviewed
Jun 7, 2019
larroy
force-pushed
the
fc_higher_order_grad
branch
from
September 11, 2019 11:12
36c6a73
to
256dfb2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Autograd
Backend
Issues related to the backend of MXNet
pr-awaiting-merge
Review and CI is complete. Ready to Merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add backward for fully connected backward.
This is not strictly correct if X or W depend on each other. After discussing with the community this a valid assumption that we can make (that the weights don't depend on the inputs).
This PR adds functionality required to get second order gradients of models using FullyConnected operator such as simple MLP.
#10002
#14619
Resolves #14991
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.