Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1377] Add static-dependencies licenses #14726

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Apr 17, 2019

Description

This PR is to add licences for all static-dependencies. These licenese are not applicable to user who chose to build from source with all depdendencies dynamically-linked. But static-linking are required to place it under the generated package (e.g pip wheel, maven jars).
@zachgk @szha

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk
Copy link
Contributor

zachgk commented Apr 17, 2019

Can you also clean up the license stuff in build_lib.sh?

@lanking520 lanking520 merged commit 818be02 into apache:master Apr 19, 2019
kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
* add static-dependencies licenses

* add rat-exclude

* kill licenses copying
@@ -48,12 +47,6 @@ if [[ $VARIANT == *mkl ]]; then
cp 3rdparty/mkldnn/build/install/lib/$IOMP_LIBFILE lib
cp 3rdparty/mkldnn/build/install/lib/$MKLML_LIBFILE lib
cp 3rdparty/mkldnn/build/install/lib/$MKLDNN_LIBFILE lib
cp 3rdparty/mkldnn/build/install/$MKLDNN_LICENSE lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to copy the mkl-dnn and cub licenses anymore?
I couldn't find them in LICENSE.binary.dependencies.

Also, these changes have broken the pip/setup.py. I will post a PR and add you as reviewer =)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also including the contents of the source LICENSE (LICENSE in the main folder) as well which contains both mkldnn and cub

@lanking520 lanking520 deleted the static-license branch June 21, 2019 22:11
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* add static-dependencies licenses

* add rat-exclude

* kill licenses copying
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants