Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Add test for gemm overflow. #14601

Closed
wants to merge 6 commits into from
Closed

[WIP] Add test for gemm overflow. #14601

wants to merge 6 commits into from

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 2, 2019

Description

Add a test for big matrix multiplications that overflow gemm int32 indexes.

This test checks that an exception is thrown instead of calling gemm with wrong indices which causes segfaults or wrong results.

For more info see related issues and PR:

#14522 dmlc/mshadow#372

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy changed the title Add test for gemm overflow. [WIP] Add test for gemm overflow. Apr 2, 2019
stu1130
stu1130 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyushghai
Copy link
Contributor

@mxnet-label-bot Add [Test]

@marcoabreu marcoabreu added the Test label Apr 2, 2019
wkcn
wkcn approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@larroy
Copy link
Contributor Author

larroy commented Apr 3, 2019

Thanks, needs mshadow PR to be merged first. Then I remove [WIP], rerun CI and merge.

@larroy
Copy link
Contributor Author

larroy commented Apr 5, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Apr 5, 2019
@Roshrini Roshrini added the pr-work-in-progress PR is still work in progress label Apr 17, 2019
@pinaraws
Copy link

@mxnet-label-bot add[pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 20, 2019
@pinaraws
Copy link

@mxnet-label-bot remove[pr-awaiting-response, pr-awaiting-review]

@pinaraws
Copy link

@mxnet-label-bot remove[pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label May 20, 2019
@pinaraws
Copy link

@larroy Please rebase so it can be merged

@larroy
Copy link
Contributor Author

larroy commented May 21, 2019

I don't think this change passes CI. I can either have another look in my next oncall or close. I don't have time in the following days to continue working on this issue.

@larroy
Copy link
Contributor Author

larroy commented May 21, 2019

@mxnet-label-bot remove [pr-awaiting-merge]

@marcoabreu marcoabreu removed the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 21, 2019
@piyushghai
Copy link
Contributor

@larroy What's the path forward here ?

@larroy
Copy link
Contributor Author

larroy commented Jun 13, 2019

I don't think I have time to look into this, so I might have to close.

@Roshrini Roshrini added pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review labels Jun 23, 2019
@larroy larroy closed this Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn approved these changes

@stu1130 stu1130 stu1130 approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-work-in-progress PR is still work in progress Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@larroy @piyushghai @pinaraws @wkcn @stu1130 @Roshrini @marcoabreu