Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix warning on macro expansion using nested defined. #14598

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 2, 2019

Fixes multiple warnings on macro expansion containing nested "defined"

warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]

Description

see title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy changed the title Fix warning on macro expansion using defined. Fix warning on macro expansion using nested defined. Apr 2, 2019
@piyushghai
Copy link
Contributor

Thanks for your contribution @larroy.

@mxnet-label-bot Add [backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Apr 2, 2019
@larroy larroy force-pushed the define_macro_ub branch 2 times, most recently from 57c31a3 to ed0dfd5 Compare April 5, 2019 18:36
warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wkcn wkcn merged commit 9443ae6 into apache:master Apr 10, 2019
@wkcn
Copy link
Member

wkcn commented Apr 10, 2019

Merged. Thank you! @larroy

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants