Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixes for CI downloads (v1.3.x) #14525

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fixes for CI downloads (v1.3.x) #14525

merged 1 commit into from
Mar 26, 2019

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Mar 26, 2019

Description

Port of #14504 to the v1.3.x branch.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lebeg
Fixes for data links
5a4b9f8 
* Changed data.dmlc.ml -> data.mxnet.io
* Added retries for downloads
* Removed silent mode for explicit failure reporting
@lebeg lebeg requested a review from nswamy as a code owner March 26, 2019 09:42
@lebeg lebeg mentioned this pull request Mar 26, 2019
Merged
jlcontreras
jlcontreras approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@jlcontreras jlcontreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just had a question

cpp-package/example/feature_extract/run.sh
wget -nc -O model/synset.txt \
http://data.mxnet.io/mxnet/models/imagenet/synset.txt
wget -nc -O model/Inception-BN-0126.params \
http://data.mxnet.io/mxnet/models/imagenet/inception-bn/Inception-BN-0126.params?raw=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why raw=true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there before 😬

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [CI, pr-awaiting-review]

@marcoabreu marcoabreu added CI pr-awaiting-review PR is waiting for code review labels Mar 26, 2019
@lanking520 lanking520 merged commit e083577 into apache:v1.3.x Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlcontreras jlcontreras jlcontreras approved these changes

@lanking520 lanking520 lanking520 approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

Assignees
No one assigned
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lebeg @abhinavs95 @jlcontreras @lanking520 @marcoabreu