Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "Fix memory leak for size-zero ndarray" #14477

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

yuxihu
Copy link
Member

@yuxihu yuxihu commented Mar 20, 2019

Reverts #14365

Removing size > 0 check in some paths caused flakiness in tests. I see two tests are failing intermittently: test_operator_gpu.test_ndarray_elementwisesum in Python2 GPU and test_sparse_parameter in Perl GPU.

Let's revert this change to make CI more stable while we are investigating further.

@yuxihu
Copy link
Member Author

yuxihu commented Mar 20, 2019

@anirudh2290 @apeforest please help merge once CI passes.

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you confirm the flakiness was caused by your change?

@yuxihu
Copy link
Member Author

yuxihu commented Mar 20, 2019

How did you confirm the flakiness was caused by your change?

One of the failures was from the code path (Storage::Get()->Free(shandle)) after I removed the size > 0 check.

@TaoLv TaoLv merged commit f98820c into apache:master Mar 20, 2019
@yuxihu yuxihu deleted the revert-14365-mem_leak branch March 20, 2019 16:01
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants