Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1361] Change 'The Straight Dope' to 'Dive into Deep Learning' on the website #14465

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

astonzhang
Copy link
Member

Description

Change The Straight Dope to Dive into Deep Learning on the website.
JIRA: https://issues.apache.org/jira/browse/MXNET-1361

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Doc update.

Comments

NA

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM

Copy link
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Please take a look at the conflict and CI failure.

@TaoLv TaoLv added the Doc label Mar 19, 2019
@astonzhang
Copy link
Member Author

astonzhang commented Mar 19, 2019

Thank you for the contribution. Please take a look at the conflict and CI failure.

@wkcn Thanks for helping me resolve the conflict!

@eric-haibin-lin eric-haibin-lin merged commit 3b28e62 into apache:master Mar 21, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants