Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix crashes on visualization #14425

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Fix crashes on visualization #14425

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6c1861
Check for kernel in Pooling
vandanavk Mar 14, 2019
c2878bd
Fix Leakyrelu visualization
vandanavk Mar 14, 2019
d5dd193
Address review comments
vandanavk Mar 14, 2019
75cf8a3
Change all occurences to string format
vandanavk Mar 14, 2019
28c14ea
Fix lint error
vandanavk Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/mxnet/visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,17 @@ def looks_like_weight(name):
elif op == "BatchNorm":
attr["fillcolor"] = cm[3]
elif op in ('Activation', 'LeakyReLU'):
label = r"%s\n%s" % (op, node["attrs"]["act_type"])
if op == "LeakyReLU":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if special handling is needed for each case, then the outer elif op in ... is not necessary.

attrs = node.get("attrs")
act_type = attrs.get("act_type", "Leaky") if attrs else "Leaky"
else:
act_type = node["attrs"]["act_type"]
label = r"%s\n%s" % (op, str(act_type))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this usage is being deprecated. use string.format instead.

attr["fillcolor"] = cm[2]
elif op == "Pooling":
label = r"Pooling\n%s, %s/%s" % (node["attrs"]["pool_type"],
"x".join(_str2tuple(node["attrs"]["kernel"])),
"x".join(_str2tuple(node["attrs"]["kernel"]))
if "kernel" in node["attrs"] else "[]",
"x".join(_str2tuple(node["attrs"]["stride"]))
if "stride" in node["attrs"] else "1")
attr["fillcolor"] = cm[4]
Expand Down