Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

v1.4.x: Backport of Windows CI Fixes #14420

Merged
merged 4 commits into from
Mar 14, 2019
Merged

v1.4.x: Backport of Windows CI Fixes #14420

merged 4 commits into from
Mar 14, 2019

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Mar 13, 2019 •
edited
Loading

Description

Backports the windows ci changes to v1.4.x branch. I've had to drop the julia tests for windows cpu, since those were added with a different Julia related PR.

Related PRs: #14355 and #14336

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva perdasilva changed the title v1.4.x: Backports Windows CI Fixes v1.4.x: Backport of Windows CI Fixes Mar 13, 2019
@perdasilva
Copy link
Contributor Author

@Chancebair @marcoabreu reviews please

@perdasilva perdasilva force-pushed the cherry_pick_windows_ci_fixes branch 2 times, most recently from 04ba493 to f4245bc Compare March 13, 2019 15:39
@Chancebair
Copy link
Contributor

LGTM

wkcn
wkcn approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM

@karan6181
Copy link
Contributor

@mxnet-label-bot add [CI, Windows, pr-awaiting-testing]

@marcoabreu marcoabreu added CI pr-awaiting-testing PR is reviewed and waiting CI build and test Windows labels Mar 13, 2019
@karan6181
Copy link
Contributor

@perdasilva Thank you for the contribution!. Could you please look into it why CI if failing?
Thanks!

@szha
Copy link
Member

szha commented Mar 14, 2019

Could you please link the related commit/PR here?

@marcoabreu marcoabreu merged commit 44265aa into apache:v1.4.x Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@Chancebair Chancebair Chancebair approved these changes

@wkcn wkcn wkcn approved these changes

Assignees
No one assigned
Labels
CI pr-awaiting-testing PR is reviewed and waiting CI build and test Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@perdasilva @Chancebair @karan6181 @szha @wkcn @marcoabreu