This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1352] Allow dynamic shape in while_loop and if conditionals #14393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
changed the title
Allow dynamic shape in while_loop and if conditionals
[MXNET-1352] Allow dynamic shape in while_loop and if conditionals
Mar 11, 2019
marcoabreu
added
Operator
pr-awaiting-review
PR is waiting for code review
pr-work-in-progress
PR is still work in progress
labels
Mar 12, 2019
@mxnet-label-bot add [Operator, pr-work-in-progress] |
junrushao
force-pushed
the
dynamic-cached-op-pr-4
branch
from
April 4, 2019 22:04
8756ea3
to
5c9b67d
Compare
This work is more complicated than expected: to let CI pass, I have to modify the graph executor... |
Symbol executor seems to be willing to work with dynamic shape now...At least I could pass unittest for control flow operators locally... |
This is kinda weird that I failed ASAN test, because my changes are not in the code path in MNIST training. Could anyone help to look at it? Thanks! Updated: fixed, never mind |
junrushao
force-pushed
the
dynamic-cached-op-pr-4
branch
5 times, most recently
from
April 13, 2019 05:02
18aa427
to
acfbb5a
Compare
@szha Finally it is done. Could you help view? Thanks! |
junrushao
force-pushed
the
dynamic-cached-op-pr-4
branch
4 times, most recently
from
April 22, 2019 06:09
6333a47
to
f28f4b9
Compare
junrushao
force-pushed
the
dynamic-cached-op-pr-4
branch
from
April 27, 2019 19:56
23b28ce
to
a9ad4c9
Compare
Finally it should work... |
zheng-da
reviewed
May 8, 2019
Review comments addressed. Are we good to merge? |
zheng-da
approved these changes
May 12, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…pache#14393) * Initial commit * Rebase * WIP for fixing rebase issues * WIP for fixing rebase issues * fix wip * wip fix * wip fix * wip fix * wip fix * wip fix * wip fix * should be good to go * wip remove debug info * wip remove debug info * linter * linter * Retrigger * Address comments from Da
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Operator
pr-awaiting-review
PR is waiting for code review
pr-work-in-progress
PR is still work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces dynamic shape in
contrib.while_loop
andcontrib.cond
to accept dynamically shaped states.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments