This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [CI, Test, Windows, pr-work-in-progress]] |
marcoabreu
added
CI
pr-work-in-progress
PR is still work in progress
Test
Windows
labels
Mar 12, 2019
If this latest commit passes CI, it will be ready for merging. The problem is that when one performs in Python:
this effects what the C++ backend sees only on Linux. Under Windows, some additional (and possibly windows-version-specific) work would be required to push the environment change to the msvcrt, which otherwise gets a copy of the environment at process start-up. My preferred fix here is to resort to the more bomb-proof approach of setting environment variables, then spawning a new process to perform the test (although admittedly this is bypassed on Python2 due to lack of spawn support). |
DickJC123
changed the title
Debug bulking test on windows [WIP]
Enable bulking test on windows
Mar 12, 2019
Ready for your review. @perdasilva @eric-haibin-lin @szha |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Reenable test_operator_gpu.py:test_bulking. * Add temporary debug output. * Add test_gluon_gpu.py:test_bulking to test spawn approach. * Reorder testing to see test_gluon_gpu.py:test_bulking result. * Change test_operator_gpu.py:test_bulking to use spawn approach. * Remove diagnostic output and revert windows ci changes.
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Reenable test_operator_gpu.py:test_bulking. * Add temporary debug output. * Add test_gluon_gpu.py:test_bulking to test spawn approach. * Reorder testing to see test_gluon_gpu.py:test_bulking result. * Change test_operator_gpu.py:test_bulking to use spawn approach. * Remove diagnostic output and revert windows ci changes.
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Reenable test_operator_gpu.py:test_bulking. * Add temporary debug output. * Add test_gluon_gpu.py:test_bulking to test spawn approach. * Reorder testing to see test_gluon_gpu.py:test_bulking result. * Change test_operator_gpu.py:test_bulking to use spawn approach. * Remove diagnostic output and revert windows ci changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a response to #14368 and is now ready for merging. The first step here was to recreate the Windows CI failure, along with additional debugging output to show whether the intended bulking environment variable settings were making it to the point of use. I learned that the test's repeated setting and altering of environment variables was not getting through to the C++ runtime under Windows, which apparently gets a copy of the environment at process start-up. The fix was to spawn a new test process for each setting of different environment variables, as is already done for the gluon version of these same tests.
Thanks to @perdasilva for identifying this issue.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments