Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Relaxing type requirements for reshape_like op #14325

Merged
merged 4 commits into from
Mar 5, 2019

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Mar 4, 2019

Description

Similarly to #14097, reshape_like op should also not dictate the type of its second argument (since only shape metadata is used there).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ptrendx ptrendx mentioned this pull request Mar 4, 2019
16 tasks
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Operator, pr-awaiting-review]

@marcoabreu marcoabreu added Operator pr-awaiting-review PR is waiting for code review labels Mar 4, 2019
@vandanavk
Copy link
Contributor

@ChaiBapchya @zhreshold for review

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Good to merge once it passes the CI

@mxnet-label-bot add [pr-awaiting-testing]

@zhreshold
Copy link
Member

Please let me know ci goes green, I can merge right after.

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [Operator, pr-awaiting-merge]

@zhreshold PR ready for merge

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Mar 5, 2019
@eric-haibin-lin eric-haibin-lin merged commit d754da3 into apache:master Mar 5, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Relax type requirements in reshape_like

* Add test

* Fix lint

* Retrigger CI
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* Relax type requirements in reshape_like

* Add test

* Fix lint

* Retrigger CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Relax type requirements in reshape_like

* Add test

* Fix lint

* Retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Operator pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants