Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add scalaclean to make clean #14322

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add scalaclean to make clean #14322

merged 1 commit into from
Mar 4, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Mar 4, 2019

Description

Add scala clean to make clean. I have it ignore errors on this command in case the user does not have maven/java installed

@piyushghai @andrewfayres @lanking520 @aaronmarkham

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from szha as a code owner March 4, 2019 19:29
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachgk
Copy link
Contributor Author

zachgk commented Mar 4, 2019

@mxnet-label-bot add [Scala, Build]

@szha szha merged commit 4d14a0b into apache:master Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@zachgk zachgk deleted the makeCleanMaster branch April 12, 2019 22:23
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants