Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

print error message for mxnet::cpp::Operator::Invoke when failed #14318

Merged
merged 4 commits into from
Mar 7, 2019

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Mar 4, 2019

Description

Hi! there.
I think it is necessary to print error message for mxnet::cpp::Operator::Invoke when there are some mistakes.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • tiny change. The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Check return value of MXImperativeInvoke, and print error message if it exists.

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@wkcn wkcn requested a review from nswamy as a code owner March 4, 2019 14:46
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Mar 4, 2019
@wkcn
Copy link
Member Author

wkcn commented Mar 5, 2019

There are some shape bugs in cpp-package.
I will resize (batchsize, 784) into (batchsize, 3, 256, 256)

@wkcn wkcn added the C++ Related to C++ label Mar 6, 2019
@szha szha merged commit 6caaa38 into apache:master Mar 7, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
…che#14318)

* raise exceptions for mxnet::cpp::Operator::Invoke when failed

* fix input shape

* fix cpplint

* fix cpp-package example shape
nswamy pushed a commit that referenced this pull request Apr 5, 2019
)

* raise exceptions for mxnet::cpp::Operator::Invoke when failed

* fix input shape

* fix cpplint

* fix cpp-package example shape
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…che#14318)

* raise exceptions for mxnet::cpp::Operator::Invoke when failed

* fix input shape

* fix cpplint

* fix cpp-package example shape
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C++ Related to C++ pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants