Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[ONNX] reverting broadcasting fixes #14299

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Mar 1, 2019

Description

@vandanavk @anirudhacharya
#13604 PR fails on some models randmly. Reverting the change for now till we find the fix.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini Roshrini requested a review from szha as a code owner March 1, 2019 23:34
@Roshrini Roshrini added the pr-awaiting-review PR is waiting for code review label Mar 1, 2019
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anirudhacharya
Copy link
Member

please reopen the original issue that the previous PR claimed to fix

@Roshrini
Copy link
Member Author

Roshrini commented Mar 1, 2019

Reopened the issue

Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Roshrini Roshrini merged commit 7aac0b5 into apache:master Mar 2, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants