Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[op] add back support for scalar type rescale_grad argument for adamw_update/mp_adamw_update #14221

Merged
merged 4 commits into from
Feb 27, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

#14171 broke backward compatibility that rescale_grad no longer supports scalar values. This PR adds it back. @szha

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we could avoid copying the doc by doing:

mp_adamw_update.__doc__ = ndarray._internal._mp_adamw_update.__doc__

Maintaining three copies of the same doc doesn't seem fun.

@roywei
Copy link
Member

roywei commented Feb 23, 2019

@mxnet-label-bot add[Operator]

@eric-haibin-lin eric-haibin-lin merged commit e3a51b5 into apache:master Feb 27, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
…_update/mp_adamw_update (apache#14221)

* support scalar

* remove two copies of documentation for adamw

* fix lint
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
…_update/mp_adamw_update (apache#14221)

* support scalar

* remove two copies of documentation for adamw

* fix lint
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
…_update/mp_adamw_update (apache#14221)

* support scalar

* remove two copies of documentation for adamw

* fix lint
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
…_update/mp_adamw_update (apache#14221)

* support scalar

* remove two copies of documentation for adamw

* fix lint
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…_update/mp_adamw_update (apache#14221)

* support scalar

* remove two copies of documentation for adamw

* fix lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants