Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disables test_random.test_exponential_generator #14188

Conversation

perdasilva
Copy link
Contributor

Description

Disables test_random.test_exponential_generator due to isse #14187

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ankkhedia
Copy link
Contributor

@perdasilva Thanks for your contribution!
@mxnet-label-bot add [Flaky, test, pr-awaiting-review]

@marcoabreu marcoabreu added Flaky pr-awaiting-review PR is waiting for code review Test labels Feb 18, 2019
@anirudhacharya
Copy link
Member

@perdasilva why are disabling this test, rather than track and fix the flakiness?

@perdasilva
Copy link
Contributor Author

@anirudhacharya the process when you find a flaky test, as I understand it, is open an issue (#14187) then create a PR to disable the test while it's fixed.

@access2rohit
Copy link
Contributor

Fix is already on the way. No need to merge this. You can close it once my fix is merged #14287

@access2rohit
Copy link
Contributor

Fix has been merged. You can close this PR now. :)

@lupesko
Copy link
Contributor

lupesko commented Mar 5, 2019

@perdasilva can you please close the issue as #14287 was merged? thanks!

@perdasilva perdasilva closed this Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Flaky pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants