Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

V1.4.x RAT check fix #14156

Merged
merged 3 commits into from
Feb 14, 2019
Merged

V1.4.x RAT check fix #14156

merged 3 commits into from
Feb 14, 2019

Conversation

szha
Copy link
Member

@szha szha commented Feb 14, 2019

Description

#14142 #14148

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

szha and others added 3 commits February 13, 2019 21:07
* remove md from whitelist

* remove rst from whitelist

* remove docker folder from whitelist

* remove docs from whitelist
* fix rendering of markdown doc

* fix missing license from lipnet example
@szha
Copy link
Member Author

szha commented Feb 14, 2019

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit 4c7fc7f into apache:v1.4.x Feb 14, 2019
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
* make rat-excludes compliant with apache release policy (apache#14142)

* remove md from whitelist

* remove rst from whitelist

* remove docker folder from whitelist

* remove docs from whitelist

* fix website build (apache#14148)

* fix rendering of markdown doc

* fix missing license from lipnet example

* fix diff
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants