Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

v1.3.x - backports nightly test fix #14145

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Feb 13, 2019

Description

The nightly job was failing because the installation instructions test was testing v1.3.x instructions against the master branch. I've updated the underlying script to filter out the git calls from the set of operations it extracts from the instruction document.
Targets #13800
Backporting: #14144

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Fixes nightly job by filtering some commands when running the installation guide test.

Comments

This commit was cherry-picked from the master branch PR #14144

@ankkhedia
Copy link
Contributor

@perdasilva Thanks for your contribution!

@mxnet-label-bot add [pr-work-in-progress, test]

@marcoabreu marcoabreu added pr-work-in-progress PR is still work in progress Test labels Feb 13, 2019
@perdasilva perdasilva mentioned this pull request Feb 13, 2019
5 tasks
@perdasilva perdasilva changed the title [WIP] Fixes installation nightly test by filtering out the git commands on v1.3.x Fixes installation nightly test by filtering out the git commands on v1.3.x Feb 13, 2019
@perdasilva
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Feb 13, 2019
@perdasilva
Copy link
Contributor Author

@mxnet-label-bot remove [pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label Feb 13, 2019
@perdasilva perdasilva force-pushed the testfix_1.3 branch 2 times, most recently from 68c4b64 to ddf7655 Compare February 14, 2019 08:26
@perdasilva perdasilva changed the title Fixes installation nightly test by filtering out the git commands on v1.3.x v1.3.x - backports nightly test fix Feb 14, 2019
@srochel
Copy link
Contributor

srochel commented Feb 14, 2019

Can you add a simple test? Does the change need to go into master and v1.4.x branch as well?

@perdasilva
Copy link
Contributor Author

perdasilva commented Feb 14, 2019

@srochel thanks for getting back to me. I don't know exactly where this test would go. This script is the test being run in CI. However, I have checked that it works by creating a custom job on the jenkins-dev

http://jenkins.mxnet-ci-dev.amazon-ml.com/blue/organizations/jenkins/per-nightly/detail/testfix_1.3/6/pipeline

This has already been merged into master #14144

I could also cherry-pick it into v1.4.x, if you like.

It would be great to merge it in asap. Then (hopefully) 1.3.x will show up green on the daily report for the first time in God knows how long ^^

@srochel srochel merged commit 87eb1ad into apache:v1.3.x Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants