Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Temporary disable gluon tutorial test #14120

Closed
wants to merge 1 commit into from

Conversation

roywei
Copy link
Member

@roywei roywei commented Feb 11, 2019

Description

Fixes #14026
Temporary disable gluon tutorial test, as it's failing the nightly test #14026

Since this only happens on CI docker envrioment, and I was not able to reproduce the test failure, I am disable this test. Although I have a potential fix here #14119, it can't be properly tested on CI for now.

Note: do not merge #14119 if this PR is merged.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Test]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Test labels Feb 11, 2019
@roywei
Copy link
Member Author

roywei commented Feb 11, 2019

closing in favor of #14119 merged. Will follow up on improving error message.

@roywei roywei closed this Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nightly Test Failure] Tutorial test_tutorials.test_gluon_end_to_end Test Failure
3 participants