This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
website publish updates #14015
Merged
website publish updates #14015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the debug flag during build, adds support for v1.4.x docs, and fixes a publish bug (that I introduced).
Regarding the bug, I needed to add an artifacts flag to
settings.iniso that I could skip trying to copy artifacts from branches where they don't exist. I could have put this logic in post processing inupdate_all_version.sh, but I liked the fact that the artifact step happens with the rest of the docs generation, so you get in with a local single version build and with a full multi-version site build.Comments
Anyone testing this might run into an error with the java/scala docs generation step. Something seems to have caused locally cached build files to break the docs generation (unrelated to this PR), so delete your
build_version_doc/apache_mxnetfolder and try again.