This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.4.x] Use CPUPinned context in ImageRecordIOParser2 #13990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create NDArray with CPUPinned context in ImageRecordIOParser2 * update document * use -1 device_id as an option to create CPU(0) context * retrigger CI * fix cpplint error
apeforest
reviewed
Jan 25, 2019
| @@ -285,9 +285,14 @@ inline bool ImageRecordIOParser2<DType>::ParseNext(DataBatch *out) { | |||
| shape_vec.push_back(param_.label_width); | |||
| TShape label_shape(shape_vec.begin(), shape_vec.end()); | |||
|
|
|||
| out->data.at(0) = NDArray(data_shape, Context::CPU(0), false, | |||
| auto ctx = Context::CPU(0); | |||
| auto dev_id = param_.device_id; | |||
There was a problem hiding this comment.
What if a device id is invalid or larger than the number of GPUs in the instance?
There was a problem hiding this comment.
It will throw error in cuda: Check failed: e == cudaSuccess || e == cudaErrorCudartUnloading CUDA: invalid device ordinal
|
@mxnet-label-bot update [pr-awaiting-merge] |
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Feb 18, 2019
…13990) * create NDArray with CPUPinned context in ImageRecordIOParser2 * update document * use -1 device_id as an option to create CPU(0) context * retrigger CI * fix cpplint error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to cherry-pick #13980 into 1.4.0 release, which fixes a significant performance regression introduced by #12666.