Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update scala-package gitignore configuration. #13962

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

frankfliu
Copy link
Contributor

Description

Update gitignore file.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@sandeep-krishnamurthy
Copy link
Contributor

@zachgk

@sandeep-krishnamurthy sandeep-krishnamurthy added Scala pr-awaiting-review PR is waiting for code review labels Jan 25, 2019
@frankfliu
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 28, 2019
@frankfliu
Copy link
Contributor Author

@mxnet-label-bot remove [pr-awaiting-review]

@marcoabreu marcoabreu removed the pr-awaiting-review PR is waiting for code review label Jan 28, 2019
@lanking520 lanking520 merged commit 7b9779a into apache:master Jan 28, 2019
@frankfliu frankfliu deleted the ignore branch January 29, 2019 03:40
jlcontreras pushed a commit to jlcontreras/incubator-mxnet that referenced this pull request Feb 14, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants