Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add back R tests and fix typo around R and perl tests #13940

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

marcoabreu
Copy link
Contributor

@marcoabreu marcoabreu commented Jan 20, 2019

This PR adds back the R tests that have been accidentally removed in my previous refactor. Sorry about that!!!

Also, I had a typo that mixed up Perl and R tests. Fixed that as well...

@jeremiedb @anirudhacharya @hetong007

@larroy
Copy link
Contributor

larroy commented Jan 20, 2019

LGTM

@marcoabreu
Copy link
Contributor Author

Seems like something isn't right:

** installing vignettes

** testing if installed package can be loaded

* DONE (devtools)



The downloaded source packages are in

	'/tmp/RtmppoYF6h/downloaded_packages'

Warning message:

In library(package, lib.loc = lib.loc, character.only = TRUE, logical.return = TRUE,  :

  there is no package called 'devtools'

Rscript -e "if(!require(devtools)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}"

Loading required package: devtools

Error in packageVersion("roxygen2") : package 'roxygen2' not found

Execution halted

Makefile:589: recipe for target 'rpkg' failed

make: *** [rpkg] Error 1

Does somebody know from the top of their head what has to be done? Otherwise, I'm happy to have a look myself.

@hetong007
Copy link
Contributor

I'm not sure what exactly caused the error.

The error means R cannot find the dependencies. If they were just installed (seems so from the log), then I suggest to look for a mismatch in the environment, for instance: do the command which installed the dependencies, and the following Rscript -e xxx refer to the same R binary?

@marcoabreu marcoabreu requested a review from szha as a code owner January 20, 2019 23:56
@@ -596,7 +596,7 @@ rpkg:
cp -rf 3rdparty/dmlc-core/include/* R-package/inst/include/
cp -rf 3rdparty/tvm/nnvm/include/* R-package/inst/include
Rscript -e "if(!require(devtools)){install.packages('devtools', repo = 'https://cloud.r-project.org/')}"
Rscript -e "if(!require(devtools)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}"
Rscript -e "if(!require(roxygen2)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremiedb could you double-check this please? You recently added this line and I assumed that it was a copy&paste leftover.

The result was that the script tried to query for the version of roxygen2 even if it was not installed, thus leading to a "null pointer exception".

@marcoabreu marcoabreu merged commit b8bb63d into apache:master Jan 21, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
* Add back R tests and fix typo around R and perl tests

* Fix permissions

* Fix copy&paste mistake around roxygen and remove previous permission override
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* Add back R tests and fix typo around R and perl tests

* Fix permissions

* Fix copy&paste mistake around roxygen and remove previous permission override
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Add back R tests and fix typo around R and perl tests

* Fix permissions

* Fix copy&paste mistake around roxygen and remove previous permission override
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants