This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[WIP] Remove redundant shared_ptr for exception_ptr #13933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxihu
changed the title
|
@mxnet-label-bot add [pr-awaiting-review] |
ChaiBapchya
suggested changes
Jan 22, 2019
|
@mxnet-label-bot update [pr-work-in-progress] |
marcoabreu
added
pr-work-in-progress
|
@yuxihu Any updates? |
|
@pinaraws Have not got a chance to look into the test failure. @anirudh2290 had explanation about why we are using shared_ptr around exception_ptr here. I think this PR is no longer needed. Closing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::exception_ptr is already reference counted. There is no need to wrap it with shared_ptr. This PR removes the redundant shared_ptr for var_exception and opr_exception members.