This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.4.x] Support populating errors back to MXNet engine in callback #13932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
approved these changes
Jan 18, 2019
|
@mxnet-label-bot update [pr-awaiting-merge] |
|
@marcoabreu Could you please help merge this PR to v1.4.x branch? Thanks. |
lanking520
approved these changes
Jan 18, 2019
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Feb 18, 2019
…pache#13932) * add an optional error_msg in engine on_complete callbcak * use dmlc::Error struct to make error population extendable
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional dmlc::Error* argument in MXNet engine callback functions. The callers can leverage this argument to populate errors back to MXNet engine through callback such that the errors can be handled properly by MXNet engine. It is needed to populate the errors detected in Horovod back to MXNet engine for Hovorod and MXNet integration (see PR). This change does not affect existing use cases.