Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.x] Fix gtest build #13926

Merged
merged 1 commit into from
Feb 14, 2019
Merged

[v1.4.x] Fix gtest build #13926

merged 1 commit into from
Feb 14, 2019

Conversation

ZhennanQin
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@stu1130
Copy link
Contributor

stu1130 commented Jan 18, 2019

@mxnet-label-bot add [pr-awaiting-review]
Thanks for your contribution @ZhennanQin

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 18, 2019
@pengzhao-intel
Copy link
Contributor

@ZhennanQin is this for master branch?

@ZhennanQin
Copy link
Contributor Author

@pengzhao-intel Master doesn't need this as master is still using old version of gtest. To avoid license issue, V1.4.x upgraded gtest and introduced this issue.

@vandanavk
Copy link
Contributor

@marcoabreu @lebeg for review

@piyushghai
Copy link
Contributor

@marcoabreu @lebeg Any concerns here with this PR for v1.4.x release ?

@lanking520 lanking520 merged commit a03d59e into apache:v1.4.x Feb 14, 2019
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
@ZhennanQin ZhennanQin deleted the v1.4.x_gtest branch September 16, 2019 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants