Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix for test always returning true #13911

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Jan 16, 2019

Description

Simple change to actually test the value of a.dtype in test_randint_without_dtype. Without this, nosetests complains:

/opt/mxnet/tests/python/gpu/../unittest/test_random.py:884: SyntaxWarning: assertion is always true, perhaps remove parentheses?
  assert(a.dtype, 'int32')

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@stu1130
Copy link
Contributor

stu1130 commented Jan 16, 2019

@mxnet-label-bot add [pr-awaiting-merge]
Thanks for your contribution @ptrendx

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 16, 2019
@TaoLv TaoLv merged commit d187060 into apache:master Jan 17, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants