This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.4.x] [MXNET-703] Update to TensorRT 5, ONNX IR 3. Fix inference bugs. #13897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a CUDA 10 cmake issue documented here: clab/dynet#1457 This fix is temporary; once an updated cmake package is published to Ubuntu's package repo it may be reverted.
KellenSunderland
force-pushed
the
trt5_mxnet_1_4
branch
from
0b73e42
to
615ee40
Compare
KellenSunderland
changed the title
KellenSunderland
force-pushed
the
trt5_mxnet_1_4
branch
from
615ee40
to
09f9e71
Compare
KellenSunderland
force-pushed
the
trt5_mxnet_1_4
branch
from
09f9e71
to
cb34855
Compare
|
@mxnet-label-bot add [pr-awaiting-review] |
|
@marcoabreu Would you be able to review this PR? It's the same as the other PR, but it makes a small change to the legacy Jenkinsfile to account for cmake builds. |
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Feb 18, 2019
…ugs. (apache#13897) * [MXNET-703] Install CUDA 10 compatible cmake This works around a CUDA 10 cmake issue documented here: clab/dynet#1457 This fix is temporary; once an updated cmake package is published to Ubuntu's package repo it may be reverted. * [MXNET-703] Update to TensorRT 5 ONNX IR 3. Fix inference bugs. * [MXNET-703] Describe onnx opsets and major version
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
…ugs. (apache#13897) * [MXNET-703] Install CUDA 10 compatible cmake This works around a CUDA 10 cmake issue documented here: clab/dynet#1457 This fix is temporary; once an updated cmake package is published to Ubuntu's package repo it may be reverted. * [MXNET-703] Update to TensorRT 5 ONNX IR 3. Fix inference bugs. * [MXNET-703] Describe onnx opsets and major version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the IR which is passed to TensorRT to use version3 of the spec, which aligns much better with MXNet defaults and results in a decrease in boilerplate code. This update also fixes some bugs when building inference engines that were resulting in feature vectors that were very different from what they should have been.
Fixes #12598
Fixes #13113
Master PR with review history: #13310
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Marco:
Resolves #13459