Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

disable default MKLDNN for cross compilation #13893

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Jan 16, 2019

Description

This PR ensures that the build flag USE_MKLDNN is set to FALSE, for cases of cross-compilation when using cmake builds. Right now, CMAKE_CROSSCOMPILING flag is TRUE only for ARM v6, v7, v8 processors.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • MKLDNN not turned on by default in case of cross compilation

@mseth10 mseth10 requested a review from szha as a code owner January 16, 2019 01:25
@TaoLv TaoLv added Build MKLDNN CMake CMake related bugs/issues/improvements labels Jan 16, 2019
@TaoLv
Copy link
Member

TaoLv commented Jan 16, 2019

@lebeg @szha Could you help to review?

@mseth10 mseth10 force-pushed the fix_cross_compilation_mkldnn branch 2 times, most recently from 0ee9cad to 9190b8d Compare January 16, 2019 23:17
@szha szha requested a review from yajiedesign January 16, 2019 23:19
@mseth10 mseth10 force-pushed the fix_cross_compilation_mkldnn branch from 9190b8d to 8725ce8 Compare January 16, 2019 23:55
Copy link
Contributor

@lebeg lebeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@stu1130
Copy link
Contributor

stu1130 commented Jan 18, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 18, 2019
@szha szha merged commit e8a2b8b into apache:master Jan 19, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
* disable default MKLDNN for cross compilation

* adding temporary debug logs
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* disable default MKLDNN for cross compilation

* adding temporary debug logs
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* disable default MKLDNN for cross compilation

* adding temporary debug logs
@mseth10 mseth10 deleted the fix_cross_compilation_mkldnn branch June 1, 2020 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build CMake CMake related bugs/issues/improvements MKLDNN pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants