Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

float32 -> float16 cast consistency across implementations #13857

Merged
merged 7 commits into from
Jan 30, 2019
Merged

float32 -> float16 cast consistency across implementations #13857

merged 7 commits into from
Jan 30, 2019

Commits on Jan 11, 2019

  1. Added test showing float32->float16 discrepancy when mshadow float2ha… 

    …lf() is used.
    @DickJC123
    DickJC123 committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    f9a901d View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Temp update mshadow submodule SHA to point to PR368 (b211cb7).

    @DickJC123
    DickJC123 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    91219ef View commit details
    Browse the repository at this point in the history

  2. Temp switch to url = https://github.com/DickJC123/mshadow.git

    @DickJC123
    DickJC123 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    b4c6c1f View commit details
    Browse the repository at this point in the history

  3. Updata mshadow submodule SHA.

    @DickJC123
    DickJC123 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    afd529c View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Improve code style per reviewer comments.

    @DickJC123
    DickJC123 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    fef0676 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Move back to dmlc/mshadow.git, now with float->half rounding.

    @DickJC123
    DickJC123 committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    ead1082 View commit details
    Browse the repository at this point in the history

  2. Expand test_operator.py:test_cast_float32_to_float16 to test np.nan.

    @DickJC123
    DickJC123 committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    91b7774 View commit details
    Browse the repository at this point in the history