Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add ccache to docs build #13832

Merged
merged 1 commit into from
Jan 17, 2019
Merged

add ccache to docs build #13832

merged 1 commit into from
Jan 17, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Jan 10, 2019

Description

see title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 10, 2019
@marcoabreu
Copy link
Contributor

Can you also try build_ccache_wrappers?

@larroy
Copy link
Contributor Author

larroy commented Jan 11, 2019

What's the advantage?

@marcoabreu
Copy link
Contributor

It's the recommended way to do it by ccache

@larroy
Copy link
Contributor Author

larroy commented Jan 16, 2019

Both methods are supported: https://ccache.samba.org/manual/latest.html

@marcoabreu
Copy link
Contributor

My personal experience was that the environment variable was ofzen not considered and the softlink had a higher success rate, but I'll leave it up to you

@larroy
Copy link
Contributor Author

larroy commented Jan 17, 2019

Works like this. If it gives problems we can switch.

@larroy
Copy link
Contributor Author

larroy commented Jan 17, 2019

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Jan 17, 2019
@marcoabreu marcoabreu merged commit 2a86978 into apache:master Jan 17, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants