Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Removes unnecessary graphics-drivers ppa repository #13814

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Removes unnecessary graphics-drivers ppa repository #13814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ci/docker/install/ubuntu_nvidia.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
# under the License.

set -ex
apt-get update || true
apt install -y software-properties-common

# Adding ppas frequently fails due to busy gpg servers, retry 5 times with 5 minute delays.
for i in 1 2 3 4 5; do add-apt-repository -y ppa:graphics-drivers && break || sleep 300; done

# Retrieve ppa:graphics-drivers and install nvidia-drivers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the ubuntu_nvidia.sh at all? CUDA is always part of the nvidia base image, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this installs the nvidia drivers and libcuda.so - which is needed by mxnet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebeg - I did a little more digging: https://github.com/apache/incubator-mxnet/blob/master/ci/docker/Dockerfile.build.ubuntu_build_cuda#L47

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Thanks!

# Note: DEBIAN_FRONTEND required to skip the interactive setup steps
Expand Down