Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update license for tvm dependencies #13797

Merged
merged 4 commits into from
Jan 9, 2019
Merged

Conversation

srochel
Copy link
Contributor

@srochel srochel commented Jan 8, 2019

Description

updated license for tvm/3rdparty/[dmcl-core,dlpack]
removed tvm/nnvm/LICENSE
removed nnvm/tvm/HalideIR/LICENSE

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [X ] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

updated license for tvm/3rdparty/[dmcl-core,dlpack]
removed tvm/nnvm/LICENSE
removed nnvm/tvm/HalideIR/LICENSE
Remove R-package/LICENSE and clojure/LICENSE as both packages are not included in release tarball.
@TaoLv TaoLv added the Licenses label Jan 8, 2019
@marcoabreu
Copy link
Contributor

Could we make the changes in the master branch and then cherrypick all the commits together within a single PR?

@srochel
Copy link
Contributor Author

srochel commented Jan 8, 2019

@aaronmarkham please review

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the conflict with my update. This PR's update still needs to be merged in master.

@aaronmarkham aaronmarkham merged commit 1a91d45 into apache:v1.4.x Jan 9, 2019
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
* update license for tvm dependencies

updated license for tvm/3rdparty/[dmcl-core,dlpack]
removed tvm/nnvm/LICENSE
removed nnvm/tvm/HalideIR/LICENSE

* removed R-package and clojure license

Remove R-package/LICENSE and clojure/LICENSE as both packages are not included in release tarball.

* added empty change to re-trigger PR check
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants