Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix website redirection issues #13796

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented Jan 8, 2019

Description

This PR updates the htaccess redirection to use a default value (master) and better handles requests coming in from different versions.

Fixes #13740.

Comments

http://34.201.8.176/faq/env_var.html - works
http://34.201.8.176/versions/master/faq/env_var.html - works
http://34.201.8.176/versions/1.4.0/faq/env_var.html - will redirect to master.
Link to env var from http://34.201.8.176/faq/index.html#extend-and-contribute-to-mxnet goes to the productions website. There's still some hijacking code going on in the publish step that should be removed so development and testing is easier and less failure prone. So for now, you have to manually enter the address for any links you want to test.
Like this one works fine: http://34.201.8.176/versions/master/faq/finetune.html or http://34.201.8.176/faq/finetune.html

With regard to why this issue is happening in the first place - I'm not sure. I'm seeing a lot of redirect issues, including the 404 page totally crashing for too many redirects. It works here in this preview. This all worked fine for many months and the htaccess file hasn't been touched in months, so 🤷‍♂️ - anyway this update seems to resolve the issue for now.

PS - the centos-gpu test finished but was hanging, so I restarted it. These successful runs but with hanging should be investigated!

@aaronmarkham aaronmarkham changed the title [WIP] fix website redirection issues fix website redirection issues Jan 8, 2019
Copy link
Contributor

@IvyBazan IvyBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is '/versions/master' the only available version? seems '/versions/1.3.1' or any version number redirect to master

@aaronmarkham
Copy link
Contributor Author

It is supposed to redirect faq requests to master. We had some old content in old versions that was inaccurate, so that's why the redirect happens. It does this for install, tutorials, etc - anything that should be current.

Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronmarkham
Copy link
Contributor Author

I'm working on what might be an even better solution, but I don't want to hold this up. This works and it fixes a problem that should be resolved ASAP, so I'm merging it.

@aaronmarkham aaronmarkham merged commit 71740ae into apache:master Jan 9, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environment variable page no longer accessible
3 participants