Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update makefile to fix MKLDNN issue #13780

Closed
wants to merge 1 commit into from

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Jan 5, 2019

Description

Fix issue #13779
@szha @azai91 @mseth10 @zachgk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from szha as a code owner January 5, 2019 19:55
@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Jan 6, 2019

@TaoLv @xinyu-intel could you help take a review?

@TaoLv
Copy link
Member

TaoLv commented Jan 6, 2019

Hi @lanking520 , thank you for looking into this issue. Seems this PR is duplicate of #13775 . Could you try if that fixes your issue?

@lanking520
Copy link
Member Author

Close this PR due to the dupes

@lanking520 lanking520 closed this Jan 6, 2019
@lanking520 lanking520 deleted the mkldnn-fix branch March 11, 2019 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants