Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix document for building with MKL-DNN on OS X (Mac) #13778

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

xinyu-intel
Copy link
Contributor

@xinyu-intel xinyu-intel commented Jan 5, 2019

Description

change c compiler from clang++ to clang when building with MKL-DNN on macOS.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here
    @TaoLv @pengzhao-intel

@xinyu-intel xinyu-intel requested a review from szha as a code owner January 5, 2019 16:03
@xinyu-intel
Copy link
Contributor Author

#13776

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix :)

@pengzhao-intel
Copy link
Contributor

@fengsky401 please help check if this can fix the issue :)

@pengzhao-intel
Copy link
Contributor

@mxnet-label-bot add [mkldnn, documentation, installation]

@szha szha merged commit 752cd0c into apache:master Jan 7, 2019
@fengsky401
Copy link

@fengsky401 please help check if this can fix the issue :)

Thank you for the changes, in mxnet setup tutorial page it's still not changed.
https://mxnet.incubator.apache.org/install/osx_setup.html

rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants