Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) #13749

Merged
merged 33 commits into from
Feb 16, 2019
Merged

Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) #13749

merged 33 commits into from
Feb 16, 2019

Commits on Nov 21, 2018

  1. Adds layout support: mx.sym.Pooling(..., layout='NHWC',...) with tests.

    @DickJC123 @ptrendx
    DickJC123 authored and ptrendx committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    cf0dc09 View commit details
    Browse the repository at this point in the history

  2. Docs changes

    @ptrendx
    ptrendx committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    55ebfb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2018

  1. Trigger

    @marcoabreu
    marcoabreu committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    79e07fd View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Skip NHWC pooling tests on non-cuDNN platforms

    @ptrendx
    ptrendx committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    4e0d0e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Fix pylint NHWC pooling

    @ptrendx
    ptrendx committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    c7e06a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Fixes from review

    @ptrendx
    ptrendx committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    7fcbdac View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Add CuDNNPoolingOp::Supports() in place of Forward()/Backward() bool … 

    …return.
    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    1d19ae5 View commit details
    Browse the repository at this point in the history

  2. Add layout support to cpu implementation of Pooling, with tests.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    6d5d8cb View commit details
    Browse the repository at this point in the history

  3. Fix cpplint.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    934f84c View commit details
    Browse the repository at this point in the history

  4. Fix bug in cpu nhwc impl.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    73fbae9 View commit details
    Browse the repository at this point in the history

  5. Add MXNet CUDA pooling in NWC, NHWC and NDHWC. Turn on 3D cuDNN pooli… 

    …ng. Tests.
    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    8654d50 View commit details
    Browse the repository at this point in the history

  6. Add PoolingParam::GetLayout() for better default layout handling.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    78d08a1 View commit details
    Browse the repository at this point in the history

  7. Fix cpplint.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    226854b View commit details
    Browse the repository at this point in the history

  8. Throw exception for quantization pooling not NCHW.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    b08747b View commit details
    Browse the repository at this point in the history

  9. Expand nhwc pooling test coverage.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    ed31a60 View commit details
    Browse the repository at this point in the history

  10. SupportMKLDNNPooling() to examine layout param.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    0dd3fba View commit details
    Browse the repository at this point in the history

  11. Compare 'std' and 'v1' pooling versions only when op definitions permit.

    @DickJC123
    DickJC123 committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    0625542 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. Add pooling test diagnostic output.

    @DickJC123
    DickJC123 committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    19d9453 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Fix syntax.

    @DickJC123
    DickJC123 committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    086ba9e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Fix pooling FInplaceOption so it can be shared by all implementations.

    @DickJC123
    DickJC123 committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    e913e0f View commit details
    Browse the repository at this point in the history

  2. Add missing param definition.

    @DickJC123
    DickJC123 committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    179a5bf View commit details
    Browse the repository at this point in the history

  3. Fix #if logic.

    @DickJC123
    DickJC123 committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    21336d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Temp switch to DickJC123/mshadow: shows effect of half round-to-neare… 

    …st on cpu.
    @DickJC123
    DickJC123 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    403bd70 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'mxnet/master' into pr_nhwc_pooling2

    @DickJC123
    DickJC123 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    d927767 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Move back to dmlc/mshadow.git, now with float->half rounding.

    @DickJC123
    DickJC123 committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    95469db View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Avoid underflow of lp pooling calc for dtype=float16.

    @DickJC123
    DickJC123 committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    098bc49 View commit details
    Browse the repository at this point in the history

  2. Remove redundant pooling test.

    @DickJC123
    DickJC123 committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    0627df4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Minor variable naming fixes.

    @DickJC123
    DickJC123 committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    16bfef0 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Modify FInplaceOption handling per reviewer comments. Expand testing.

    @DickJC123
    DickJC123 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    7506c1b View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. Correct gluon Pooling layout param description.

    @DickJC123
    DickJC123 committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    7ac90ee View commit details
    Browse the repository at this point in the history

  2. Correct Symbol Pooling description.

    @DickJC123
    DickJC123 committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    a2a2103 View commit details
    Browse the repository at this point in the history

  3. Use 'CHECK(x)' rather than 'if (x) LOG(FATAL)'.

    @DickJC123
    DickJC123 committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    a86be07 View commit details
    Browse the repository at this point in the history

  4. Empty commit to trigger CI.

    @DickJC123
    DickJC123 committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    f773a90 View commit details
    Browse the repository at this point in the history