Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

disable error checking when building old versions #13725

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

aaronmarkham
Copy link
Contributor

Description

This PR fixes a bug in the options settings for the docs build for the website publishing job in CI. If you ran master first the error checking would get turned on and then never turn off for the older versions.

Testing

This will fail now:
./build_all_version.sh "master;v1.3.x" "master;1.3.1"
So the workaround is to run master last, but with this PR, it will work generating different versions in any order.

@@ -122,6 +122,8 @@ function checkout () {
git pull
# master gets warnings as errors for Sphinx builds
OPTS="-W"
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTS is already empty (set at line 47). Why is this required? If tag is master OPTS is set to "-w" otherwise it is left as is which is empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once master gets called OPTS is set, but when another version is called it should be unset.

@sandeep-krishnamurthy sandeep-krishnamurthy added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Dec 29, 2018
@aaronmarkham aaronmarkham merged commit a38278d into apache:master Jan 2, 2019
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-merge Review and CI is complete. Ready to Merge Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants