Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Don't merge] Test ILP64 #13723

Closed
wants to merge 10 commits into from
Closed

[Don't merge] Test ILP64 #13723

wants to merge 10 commits into from

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Dec 24, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested a review from szha as a code owner December 24, 2018 04:49
@Roshrini
Copy link
Member

Roshrini commented Jan 8, 2019

@TaoLv Is this PR still WIP?

@TaoLv
Copy link
Member Author

TaoLv commented Jan 10, 2019

Close for now.

@TaoLv TaoLv closed this Jan 10, 2019
@TaoLv TaoLv reopened this Mar 11, 2019
@piyushghai
Copy link
Contributor

@TaoLv I see that you've opened up this PR again. Is it still a work in progress ?

@karan6181
Copy link
Contributor

@TaoLv Could you please look into this PR and drive it to Merge? Thanks!

@TaoLv
Copy link
Member Author

TaoLv commented May 22, 2019

@karan6181 I will close this PR for now. I think it should be included as a part of the proposal/design for large tensor. @pengzhao-intel @apeforest @szha

@TaoLv TaoLv closed this May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants