Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

onnx export operators added #13641

Closed
wants to merge 8 commits into from
Closed

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Dec 13, 2018

Description

Adding operators - LogisticRegressionOutput, MakeLoss, BlockGrad, _rminus_scalar, r_div_scalar, identity

Cleaning this #12946

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Roshrini Roshrini requested a review from szha as a code owner December 13, 2018 23:50
@roywei
Copy link
Member

roywei commented Dec 14, 2018

@mxnet-label-bot add[ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Dec 14, 2018
@Roshrini Roshrini force-pushed the some_onnx_ops branch 2 times, most recently from fbeae41 to 24cd6db Compare December 19, 2018 21:47
@Roshrini Roshrini changed the title [WIP] onnx export operators added onnx export operators added Dec 26, 2018
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roshrini Roshrini mentioned this pull request Jan 9, 2019
6 tasks
@Roshrini
Copy link
Member Author

Roshrini commented Jan 9, 2019

Created new PR - #13821

@Roshrini Roshrini closed this Jan 9, 2019
@Roshrini Roshrini deleted the some_onnx_ops branch January 9, 2019 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants