Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Added logging to GitHub commit status publishing #13615

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Dec 11, 2018

Description

Currently, sometimes there is a problem with GitHub status updates:

If repoUrl is changed to a not valid url the log shows the exact same error:

[Set GitHub commit status (universal)] SUCCESS on repos [] (sha:90a0bd0) with context:ci/jenkins/mxnet-validation/windows-gpu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Dec 11, 2018
@lebeg
Copy link
Contributor Author

lebeg commented Dec 12, 2018

The ci/jenkins/mxnet-validation/unix-cpu job succeeded, but status did not propagate.

@sandeep-krishnamurthy
Copy link
Contributor

@lebeg - This is a helpful change. Can we go ahead and merge this?

@lebeg
Copy link
Contributor Author

lebeg commented Jan 7, 2019

@sandeep-krishnamurthy yes, please merge

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit b1c9c2a into apache:master Jan 16, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants