-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@aaronmarkham Please take a look. I removed the Scala files that were causing warnings (we talked about offline) as you've edited those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one suggestion about the link, but it is totally minor... if this passes CI, I'd like to get the fixes in ASAP, and worry about relative links another time.
Let's also hear back from @eric-haibin-lin and @zheng-da about the symbol/contrib page, but they're good with it, then this is GTG.
@@ -55,9 +55,6 @@ In the rest of this document, we list routines provided by the `symbol.contrib` | |||
foreach | |||
while_loop | |||
cond | |||
isinf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just encountered this as well. I think it is ok to remove...
I made a likewise comment and am awaiting confirmation.
docs/faq/develop_and_hack.md
Outdated
- [Contributor Guidelines](http://mxnet.io/community/contribute.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're updating links, please switch them to relative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just removes an invisible character that's causing a sphinx warning about a hard line break that was illegal.
But I'll update the two links to be relative as well
@@ -82,7 +82,6 @@ def forward(self, F, inputs, tree): | |||
for child in tree.children] | |||
#Recursively builds the neural network based on each input sentence’s | |||
#syntactic structure during the model definition and training process | |||
… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this breaking something or is your editor linting things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing an warning about this block, and when this char was removed, I was able to remove that warning (illegal UTF-8)
@@ -795,7 +795,8 @@ uniform probability. | |||
|
|||
out[2] | |||
[0 0 0 0 0] | |||
<NDArray 5 @cpu(0)> | |||
<NDArray 5 @cpu(0)> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this to be a problem as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Ok, we're good to remove those entries on the symbol page. |
@aaronmarkham Updated as per comments including the relative links. thanks! |
Description
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
NCCL)