This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[WIP] Feature/mklnn default make + test on jenkins #13464
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-mxnet into feature/mklnn-default-make
szha
reviewed
Dec 14, 2018
@@ -132,7 +136,7 @@ ifeq ($(USE_MKLDNN), 1) | |||
LDFLAGS += -L$(MKLROOT)/lib | |||
endif | |||
CFLAGS += -I$(MKLDNNROOT)/include | |||
LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}' | |||
LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,$(ROOTDIR)/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want a hard-coded path as rpath?
@iblis17 can you take a look at the julia build and see why it fails when MKLDNN is enabled? |
The log looks weird:
It doesn't match the code in this PR
The line |
And I built a julia> using MXNet
julia> ENV["MXNET_HOME"]
"/home/iblis/git/mxnet-mkl"
julia> foreach(Libdl.dllist()) do x
if !contains(x,"mx")
return
end
@show x
end
x = "/home/iblis/git/mxnet-mkl/lib/libmxnet.so"
x = "/home/iblis/git/mxnet-mkl/lib/libmklml_intel.so"
x = "/home/iblis/git/mxnet-mkl/lib/libiomp5.so"
x = "/home/iblis/git/mxnet-mkl/lib/libmkldnn.so.0" |
szha
suggested changes
Dec 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rpath change looks wrong
This was referenced Dec 18, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments