Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove redundant link #13428

Merged
merged 3 commits into from
Nov 29, 2018

Conversation

azai91
Copy link
Contributor

@azai91 azai91 commented Nov 27, 2018

Description

Remove redundant line in build from source doc

https://www.dropbox.com/s/lr3ngjvh16hlnv3/Screenshot%202018-11-27%2015.23.26.png?dl=0

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Remove redundant line in build from source doc

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@azai91 azai91 requested a review from szha as a code owner November 27, 2018 23:24
@vandanavk
Copy link
Contributor

@nswamy for review/merge

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Nov 28, 2018
@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Doc pr-awaiting-review PR is waiting for code review labels Nov 29, 2018
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that PR passes CI
LGTM
@anirudh2290 Could you approve and merge this?

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit d7b9bea into apache:master Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants