Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Correct Inception Reference for Pertained Model #13360

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Correct Inception Reference for Pertained Model #13360

merged 1 commit into from
Nov 29, 2018

Conversation

lou-k
Copy link
Contributor

@lou-k lou-k commented Nov 21, 2018

Description

Update Model Zoo Documentation

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Remove 'v3' from reference documentation
  • Update research bias link

Comments

I noticed that the symbols and parameters in the model zoo are in fact from https://github.com/apache/incubator-mxnet/blob/master/example/image-classification/symbols/inception-bn.py, which is not inception v3. It is inception + batch normalization.

In this commit, I update the documentation and link to the correct research basis.

@lou-k lou-k requested a review from szha as a code owner November 21, 2018 20:55
@stu1130
Copy link
Contributor

stu1130 commented Nov 21, 2018

@mxnet-label-bot add [pr-awaiting-review]
Thanks for your contribution @lou-k

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Nov 21, 2018
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandanavk
Copy link
Contributor

@aaronmarkham for review

@lou-k could you check the failing CI?

I noticed that the symbols and parameters in the model zoo are infact from https://github.com/apache/incubator-mxnet/blob/master/example/image-classification/symbols/inception-bn.py, which is not inception v3. It is inception + batch normalization. 

In this commit, I update the documentation and link to the correct research basis.
@lou-k
Copy link
Contributor Author

lou-k commented Nov 27, 2018

@vandanavk it looks like the CI check was canceled:

ERROR: Queue task was cancelled
Finished: FAILURE

I rebased and push to trigger a new build.

@lou-k
Copy link
Contributor Author

lou-k commented Nov 28, 2018

@vandanavk CI passed. thanks for your eyes on this!

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 28, 2018
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 859d294 into apache:master Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants