Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1110] find the path to include header files #13359

Merged
merged 10 commits into from
Nov 28, 2018
Merged

[MXNET-1110] find the path to include header files #13359

merged 10 commits into from
Nov 28, 2018

Conversation

apeforest
Copy link
Contributor

Description

This feature is required by Horovod integration.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

Changes

  • a new python method

@apeforest apeforest requested a review from szha as a code owner November 21, 2018 20:38
@apeforest
Copy link
Contributor Author

@szha Please help to review if the path is consistent with pip package. Thanks!

@apeforest
Copy link
Contributor Author

apeforest commented Nov 21, 2018 •
edited
Loading

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Nov 21, 2018
yuxihu
yuxihu suggested changes Nov 21, 2018
View reviewed changes
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
python/mxnet/libinfo.py Show resolved Hide resolved
ChaiBapchya
ChaiBapchya reviewed Nov 22, 2018
View reviewed changes
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
yuxihu
yuxihu suggested changes Nov 27, 2018
View reviewed changes
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
python/mxnet/libinfo.py Show resolved Hide resolved
python/mxnet/libinfo.py Show resolved Hide resolved
yuxihu
yuxihu approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest
Copy link
Contributor Author

@szha @marcoabreu @anirudh2290 Please help to merge this if no other comment.

@apeforest
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 27, 2018
@szha szha requested a review from zhreshold November 27, 2018 22:17
zhreshold
zhreshold reviewed Nov 27, 2018
View reviewed changes
python/mxnet/libinfo.py Outdated Show resolved Hide resolved
@anirudh2290 anirudh2290 merged commit 9288527 into apache:master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya left review comments

@zhreshold zhreshold zhreshold approved these changes

@yuxihu yuxihu yuxihu approved these changes

@anirudh2290 anirudh2290 anirudh2290 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apeforest @anirudh2290 @yuxihu @zhreshold @ChaiBapchya @marcoabreu