Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add imresize and copyMakeBorder to mx.image #13357

Merged
merged 3 commits into from
Dec 11, 2018

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Nov 21, 2018

Description

Though mx.image.imresize and mx.image.copyMakeBorder is currently available for external use, it does not show up in the docs because it was hidden behind an internal function call.

reference - #12831 (comment)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@stu1130
Copy link
Contributor

stu1130 commented Nov 21, 2018

@mxnet-label-bot add [pr-awaiting-review]
Thanks for your contribution @anirudhacharya

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Nov 21, 2018
@anirudhacharya anirudhacharya force-pushed the resizeDocs branch 2 times, most recently from 2838d22 to efebff1 Compare November 23, 2018 01:23
python/mxnet/image/image.py Show resolved Hide resolved
python/mxnet/image/image.py Show resolved Hide resolved
python/mxnet/image/image.py Show resolved Hide resolved
@vandanavk
Copy link
Contributor

@frankfliu @aaronmarkham for review

@stu1130
Copy link
Contributor

stu1130 commented Dec 10, 2018

@anirudhacharya could you address the CI failure? I will use the resize you exported to test my operator Thanks!

Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 75d1d4f into apache:master Dec 11, 2018
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Dec 13, 2018
* upstream/master:
  [MXNET-1253] fix control_flow_op (apache#13555)
  Add imresize and copyMakeBorder to mx.image (apache#13357)
@anirudhacharya anirudhacharya deleted the resizeDocs branch January 16, 2019 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants